Skip to content

[FEATURE] Add internal getters to Settings and use them #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[FEATURE] Add internal getters to Settings and use them #1013

merged 1 commit into from
Feb 27, 2025

Conversation

oliverklee
Copy link
Collaborator

Also make a type annotation more specific along the way.

@oliverklee oliverklee requested a review from JakeQZ February 27, 2025 09:35
@oliverklee oliverklee self-assigned this Feb 27, 2025
@coveralls
Copy link

coveralls commented Feb 27, 2025 •
edited
Loading

Coverage Status

coverage: 54.655% (+0.1%) from 54.512%
when pulling 1c4bc77 on cleanup/use-settings-accessors
into e1f8bd3 on main.

@oliverklee oliverklee changed the title [FEATURE] Add and use internal getters to Settings [FEATURE] Add internal getters to Settings and use them Feb 27, 2025
@oliverklee
[FEATURE] Add internal getters to Settings and use them
1c4bc77 
Also make a type annotation more specific along the way.
@oliverklee oliverklee force-pushed the cleanup/use-settings-accessors branch from bee14a0 to 1c4bc77 Compare February 27, 2025 09:54
JakeQZ
JakeQZ approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat. This means the properties can now be made private.

@JakeQZ JakeQZ merged commit 09c8f83 into main Feb 27, 2025
21 checks passed
@JakeQZ JakeQZ deleted the cleanup/use-settings-accessors branch February 27, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
cleanup enhancement
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ