Skip to content

[TASK] Make the OutputFormat properties private #1014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[TASK] Make the OutputFormat properties private #1014

merged 1 commit into from
Feb 27, 2025

Conversation

oliverklee
Copy link
Collaborator

Also use the accessors as necessary.

Fixes #882

@oliverklee
[TASK] Make the OutputFormat properties private
966b11b 
Also use the accessors as necessary.

Fixes #882
@oliverklee oliverklee requested a review from JakeQZ February 27, 2025 09:49
@oliverklee oliverklee self-assigned this Feb 27, 2025
@coveralls
Copy link

Coverage Status

coverage: 54.512%. remained the same
when pulling 966b11b on task/private-outputformat-properties
into e1f8bd3 on main.

JakeQZ
JakeQZ approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat.

@JakeQZ JakeQZ merged commit a06211d into main Feb 27, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/private-outputformat-properties branch February 27, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Make all properties of OutputFormat private
3 participants
@oliverklee @coveralls @JakeQZ