Skip to content

[TASK] Deprecate greedy calculation of selector specificity #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 27, 2025
Merged

[TASK] Deprecate greedy calculation of selector specificity #1018

merged 1 commit into from
Feb 27, 2025

Conversation

oliverklee
Copy link
Collaborator

This constructor parameter is not used, and having the specificity calculation always done lazily is not a problem.

@oliverklee oliverklee requested a review from JakeQZ February 27, 2025 11:14
@oliverklee oliverklee self-assigned this Feb 27, 2025
@coveralls
Copy link

coveralls commented Feb 27, 2025 •
edited
Loading

Coverage Status

coverage: 54.655%. remained the same
when pulling b2e2267 on task/deprecate/selector-specificity
into a06211d on main.

@oliverklee oliverklee force-pushed the task/deprecate/selector-specificity branch from 69278ac to b2c5b62 Compare February 27, 2025 11:16
@oliverklee
[TASK] Deprecate greedy calculation of selector specificity
b2e2267 
This constructor parameter is not used, and having the
specificity calculation always done lazily is not a problem.
@oliverklee oliverklee force-pushed the task/deprecate/selector-specificity branch from b2c5b62 to b2e2267 Compare February 27, 2025 11:19
JakeQZ
JakeQZ approved these changes Feb 27, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, it can be done on first-time access without loss of performance.

@JakeQZ JakeQZ merged commit e0392d0 into main Feb 27, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/deprecate/selector-specificity branch February 27, 2025 11:47
oliverklee added a commit that referenced this pull request Feb 27, 2025
@oliverklee
[TASK] Deprecate greedy calculation of selector specificity
d6fdff0 
This constructor parameter is not used, and having the
specificity calculation always done lazily is not a problem.

This is the V8.x backport of #1018.
@oliverklee oliverklee mentioned this pull request Feb 27, 2025
Merged
JakeQZ pushed a commit that referenced this pull request Feb 27, 2025
@oliverklee
[TASK] Deprecate greedy calculation of selector specificity (#1022)
a9fede8 
This constructor parameter will no longer be used;
having the specificity calculation always done lazily is not a problem.

This is the V8.x backport of #1018.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@oliverklee oliverklee

Labels
to-backport
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ