Skip to content

[CLEANUP] Avoid magic method forwarding in Document #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JakeQZ merged 1 commit into from
Mar 12, 2025
Merged

[CLEANUP] Avoid magic method forwarding in Document #1155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions config/phpstan-baseline.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,6 @@ parameters:
count: 1
path: ../src/CSSList/CSSList.php

-
message: '#^Call to an undefined method Sabberworm\\CSS\\OutputFormat\:\:comments\(\)\.$#'
identifier: method.notFound
count: 1
path: ../src/CSSList/Document.php

-
message: '#^Parameters should have "string\|null" types as the only types passed to this method$#'
identifier: typePerfect.narrowPublicClassMethodParamType
Expand Down
2 changes: 1 addition & 1 deletion src/CSSList/Document.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ public function render(?OutputFormat $outputFormat = null): string
if ($outputFormat === null) {
$outputFormat = new OutputFormat();
}
return $outputFormat->comments($this) . $this->renderListContents($outputFormat);
return $outputFormat->getFormatter()->comments($this) . $this->renderListContents($outputFormat);
}

public function isRootList(): bool
Expand Down