Consume expression to indicate how many characters to look ahead #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Where possible consumeExpression should be provided with the maximum number of characters the expression could be made of. This allows for more efficiently peeking for a few characters rather than the entire remaining character map.
|
Travis may fail, but here is my local PHP Unit output: |
|
Good idea, thanks! (I’ll fix travis later) |
|
Fastest merge ever! W00t! |
|
FMCorz you beautiful man! |
danpoltawski
added a commit
to danpoltawski/moodle
that referenced
this pull request
Jun 2, 2017
This version includes a fix[1] contributed by Frédéric Massart investigating our compilation time issues, which significantly improves the speed of processing font awesome. Thanks, Fred! [1] MyIntervals/PHP-CSS-Parser#120
danpoltawski
added a commit
to danpoltawski/moodle
that referenced
this pull request
Jun 2, 2017
This version includes a fix[1] contributed by Frédéric Massart investigating our compilation time issues, which significantly improves the speed of processing font awesome. Thanks, Fred! [1] MyIntervals/PHP-CSS-Parser#120
danpoltawski
added a commit
to danpoltawski/moodle
that referenced
this pull request
Jun 2, 2017
This version includes a fix[1] contributed by Frédéric Massart investigating our compilation time issues, which significantly improves the speed of processing font awesome. Thanks, Fred! [1] MyIntervals/PHP-CSS-Parser#120
|
Released with 8.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where possible consumeExpression should be provided with the maximum number of characters the expression could be made of. This allows for more efficiently peeking for a few characters rather than the entire remaining character map.
This issue was discovered at Moodle when compiling with FontAwesome which uses unicode more heavily. https://tracker.moodle.org/browse/MDL-58646