Skip to content

[TASK] Add trait providing standard implementation of Commentable #1206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 4 commits into from
Mar 25, 2025
Merged

[TASK] Add trait providing standard implementation of Commentable #1206

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fa0e11c
[TASK] Add trait providing standard implementation of `Commentable`
JakeQZ Mar 21, 2025
de45497
With PHPStan, require trait users to implement `Commentable`
JakeQZ Mar 22, 2025
94a17b4
Change test subject type to `ConcreteCommentContainer`
JakeQZ Mar 25, 2025
65bb1e7
Rename test methods to focus on the main method under test
JakeQZ Mar 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
With PHPStan, require trait users to implement Commentable
  • Loading branch information
@JakeQZ
JakeQZ committed Mar 22, 2025
commit de45497e0acb0edf7bb2cd1a0dd80ff51c744155
2 changes: 2 additions & 0 deletions src/Comment/CommentContainer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
* Provides a standard reusable implementation of `Commentable`.
*
* @internal
*
* @phpstan-require-implements Commentable
*/
trait CommentContainer
{
Expand Down