Skip to content

[TASK] Add separate methods for RuleSet::removeRule(), with deprecation #1251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 5, 2025
Merged

[TASK] Add separate methods for RuleSet::removeRule(), with deprecation #1251

merged 1 commit into from
May 5, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented May 4, 2025

Passing a string or null to removeRule() is deprecated. The new methods handle that functionality.

Relates to #1247.

This is the backport of #1249.

@JakeQZ JakeQZ added cleanup deprecation A method, property, or some functionality has been deprecated. refactor For PRs that refactor code without changing functionality backport labels May 4, 2025
@JakeQZ JakeQZ requested a review from oliverklee May 4, 2025 22:47
@JakeQZ JakeQZ self-assigned this May 4, 2025
@JakeQZ JakeQZ marked this pull request as draft May 4, 2025 22:47
@JakeQZ JakeQZ force-pushed the backport/1249 branch 9 times, most recently from 726967e to b94cd96 Compare May 4, 2025 23:24
@JakeQZ JakeQZ marked this pull request as ready for review May 4, 2025 23:25
@JakeQZ JakeQZ mentioned this pull request May 4, 2025
Merged
@JakeQZ
[TASK] Add separate methods for RuleSet::removeRule(), with depreca…
c329373 
…tion

Passing a `string` or `null` to `removeRule()` is deprecated.
The new methods handle that functionality.

Relates to #1247.

This is the backport of #1249.
@oliverklee oliverklee merged commit a14dc83 into v8.x May 5, 2025
22 checks passed
@oliverklee oliverklee deleted the backport/1249 branch May 5, 2025 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliverklee oliverklee oliverklee approved these changes

Assignees

@JakeQZ JakeQZ

Labels
backport cleanup deprecation A method, property, or some functionality has been deprecated. refactor For PRs that refactor code without changing functionality
Projects
None yet
Milestone
8.9.0: Deprecations and bug fixes
Development

Successfully merging this pull request may close these issues.
2 participants
@JakeQZ @oliverklee