Skip to content

[TASK] Add tests for RuleSet::addRule() without sibling argument #1269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jun 3, 2025

Some are currently skipped, pending some minor bug fixes.

This is the backport of #1261.

@JakeQZ JakeQZ requested a review from oliverklee June 3, 2025 16:39
@JakeQZ JakeQZ self-assigned this Jun 3, 2025
@JakeQZ JakeQZ added testing PRs/issues adding additional tests only, or primarily testing-focused backport labels Jun 3, 2025
@JakeQZ JakeQZ force-pushed the test/v8.x/addrule branch 2 times, most recently from e17434a to 3f69503 Compare June 3, 2025 16:44
@JakeQZ JakeQZ marked this pull request as draft June 3, 2025 16:56
Some are currently skipped, pending some minor bug fixes.

This is the backport of #1261.
@JakeQZ JakeQZ force-pushed the test/v8.x/addrule branch from 3f69503 to 83bede2 Compare June 3, 2025 21:41
@JakeQZ JakeQZ marked this pull request as ready for review June 3, 2025 21:42
@oliverklee oliverklee merged commit 7a469b2 into v8.x Jun 3, 2025
22 checks passed
@oliverklee oliverklee deleted the test/v8.x/addrule branch June 3, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport testing PRs/issues adding additional tests only, or primarily testing-focused
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants