Skip to content

[TASK] Add tests for RuleSet::getRulesAssoc with $searchPattern #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 4 commits into from
Jun 21, 2025
Merged

[TASK] Add tests for RuleSet::getRulesAssoc with $searchPattern #1280

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b7c90b1
[TASK] Add tests for `RuleSet::getRulesAssoc` with `$searchPattern`
JakeQZ Jun 19, 2025
8c7419c
Add separate test for non-matching patterns
JakeQZ Jun 19, 2025
a32a698
Use `assertArrayHasKey()`
JakeQZ Jun 19, 2025
fcca94e
Use single test method check that exactly all property names are matched
JakeQZ Jun 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use single test method check that exactly all property names are matched
  • Loading branch information
@JakeQZ
JakeQZ committed Jun 20, 2025
commit fcca94e4f02132c8f799b9742caad1ea68b0961b
30 changes: 4 additions & 26 deletions tests/Unit/RuleSet/RuleSetTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1182,32 +1182,10 @@ public function getRulesAssocWithPatternReturnsAllMatchingPropertyNames(

$result = $this->subject->getRulesAssoc($searchPattern);

foreach ($matchingPropertyNames as $expectedMatchingPropertyName) {
self::assertArrayHasKey($expectedMatchingPropertyName, $result);
}
}

/**
* @test
*
* @param list<string> $propertyNamesToSet
* @param list<string> $matchingPropertyNames
*
* @dataProvider providePropertyNamesAndSearchPatternAndMatchingPropertyNames
*/
public function getRulesAssocWithPatternFiltersNonMatchingRules(
array $propertyNamesToSet,
string $searchPattern,
array $matchingPropertyNames
): void {
$this->setRulesFromPropertyNames($propertyNamesToSet);

$result = $this->subject->getRulesAssoc($searchPattern);

foreach ($result as $resultRule) {
// 'expected' and 'actual' are transposed here due to necessity
self::assertContains($resultRule->getRule(), $matchingPropertyNames);
}
$resultPropertyNames = \array_keys($result);
\sort($matchingPropertyNames);
\sort($resultPropertyNames);
self::assertSame($matchingPropertyNames, $resultPropertyNames);
}

/**
Expand Down