Skip to content

[BUGFIX] Exclude absent line number from exception message #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 2 commits into from
Jun 26, 2025
Merged

[BUGFIX] Exclude absent line number from exception message #1290

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4c0db8
[BUGFIX] Exclude absent line number from exception message
JakeQZ Jun 26, 2025
6cc6b3d
Include the fix as well as the test changes
JakeQZ Jun 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Include the fix as well as the test changes
  • Loading branch information
@JakeQZ
JakeQZ committed Jun 26, 2025
commit 6cc6b3da555e3f65ea2c20334d55cd16a0235ced
2 changes: 1 addition & 1 deletion src/Parsing/SourceException.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ class SourceException extends \Exception implements Positionable
public function __construct(string $message, ?int $lineNumber = null)
{
$this->setPosition($lineNumber);
if ($lineNumber !== 0) {
if ($lineNumber !== null) {
$message .= " [line no: $lineNumber]";
}
parent::__construct($message);
Expand Down