Skip to content

[BUGFIX] Allow comma-separated arguments in selectors #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oliverklee merged 5 commits into from
Jul 10, 2025
Merged

[BUGFIX] Allow comma-separated arguments in selectors #1292

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0425f1e
[BUGFIX] Allow comma-separated arguments in selectors
JakeQZ Jun 28, 2025
7a06c91
Don't consume character after `,` without checking
JakeQZ Jul 8, 2025
18756bf
Fix typo in CHANGELOG.md
JakeQZ Jul 8, 2025
4fa98e3
Succinct changelog entry
JakeQZ Jul 10, 2025
0612c65
Test rejection of selectors with unmatched parentheses
JakeQZ Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Don't consume character after , without checking 
Also remove fix for `consumeUntil` bug, which #1320 will address.
  • Loading branch information
@JakeQZ
JakeQZ committed Jul 10, 2025
commit 7a06c91a6f295e569136fc31e263a53516e0ee65
4 changes: 0 additions & 4 deletions src/Parsing/ParserState.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,10 +345,6 @@ public function consumeUntil(
$start = $this->currentPosition;

while (!$this->isEnd()) {
$comment = $this->consumeComment();
if ($comment instanceof Comment) {
$comments[] = $comment;
}
$character = $this->consume(1);
if (\in_array($character, $stopCharacters, true)) {
if ($includeEnd) {
Expand Down