[BUGFIX] Allow commas in attributes in setSelectors
#1419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue noted in #1324.
oliverklee
requested changes
Dec 9, 2025
| */ | ||
| public function setSelectorsThrowsExceptionWithInvalidSelector(string $selector): void | ||
| { | ||
| $this->expectException(UnexpectedTokenException::class); |
Collaborator
There was a problem hiding this comment.
We should also check for the exception message.
Collaborator
Author
There was a problem hiding this comment.
I looked at the messages and found they were unhelpful, so have fixed that.
I also found that the exceptions thrown by the code when { or end of string were not as expected were not being tested, so have added more test data for that.
Also make it more useful. And add additional test data to fully exercise the code.
oliverklee
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue noted in #1324.