You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I’m not quite on board with parsing these as literals. I guess a custom Value subclass UnicodeRange would be more appropriate. It could then also provide methods to check if a code point is included in the range…
Hm, I thought these were supposed to always be literals. Having a separate Value subclass sounds good, but honestly I am not sure when will I have time to do it. I was able to update this PR since the old code was reusable. As of now, this PR at least helps to keep the unicode ranges in the rendered CSS, otherwise these rules get removed.
It would be great if you(or anybody) can add the UnicodeRange type and complete the implementation, if not I will ask you to at least merge this PR as is and open an issue for the suggested improvements.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The unicode-range property (https://developer.mozilla.org/en-US/docs/Web/CSS/@font-face/unicode-range) is currently not supported. This PR adds support for that.