Fix undefined index notice when property lacks value #154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabberworm
requested changes
Jan 28, 2019
Collaborator
sabberworm
left a comment
There was a problem hiding this comment.
Thanks. I think we should leverage the existing distinction between strict and lenient parsing modes.
Also, could you maybe add a unit test for this?
lib/Sabberworm/CSS/Value/Value.php
Outdated
| } | ||
| } | ||
| if (!isset($aStack[0])) { | ||
| return null; |
Collaborator
There was a problem hiding this comment.
Could you try to instead to throw a custom UnexpectedTokenException which, in lenient mode, should be caught already.
Collaborator
Author
|
@sabberworm thanks for the review. I've added the throwing of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given this CSS:
I'm getting a PHP notice:
This PR fixes that problem by improving the resiliency to bad CSS.