Improve EOF handling + handle lonely import statements #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Complexity increasing per file
==============================
- tests/Sabberworm/CSS/ParserTest.php 14
- lib/Sabberworm/CSS/Parsing/ParserState.php 11
- lib/Sabberworm/CSS/CSSList/CSSList.php 22
See the complete overview on Codacy |
sabberworm
reviewed
Nov 12, 2019
sabberworm
reviewed
Nov 12, 2019
sabberworm
reviewed
Nov 12, 2019
sabberworm
reviewed
Nov 12, 2019
sabberworm
reviewed
Nov 12, 2019
westonruter
added a commit
to westonruter/PHP-CSS-Parser
that referenced
this pull request
Apr 20, 2020
…into fix/selector-comma-parsing * 'master' of https://github.com/sabberworm/PHP-CSS-Parser: (64 commits) Preserve casing for CSS var names Fix @import's output when there is no media query Convert some more code to make use of ParserState::EOF and UnexpectedEOFException Trim the Import's media query Add forgotten check for document end Resolve issues with using exceptions for flow control Resolve MyIntervals#176 (comment) Add ParserState::EOL and support it in consumeUntil Remove trailing newline from the lonely-import test file Replace assumption with certainty for EOF when consuming white space Fix PHP 5.3 compatibility Fix CSSList::replace with object as the new value Improve EOF handling + handle lonely import statements Fix PHP 7.3 warning when using count() on non-array value Remove an extra 'i' char Add test for validating keyframe selectors Improve the selector validation to support % based steps in a keyframe definition Bug fix in parsing size units Simplify the CSS validating regex Move selector validation outside of the Selector's constructor ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #175