Skip to content

Test enhancement #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

peter279k
Copy link
Contributor

Changed log

  • Add php-7.4 version test during Travis CI build.
  • Let composer.lock be removed on Git version control and it can avoid caching dependencies.
  • Using the PHPUnit ^4.8.36 version to support future PHPUnit versions.
  • Using the \PHPUnit\Framework\TestCase namespace to be compatible with future PHPUnit versions.
  • Using the assertCount to assert expected count is same as result count.
  • Using assertTrue or assertFalse to assert that expected value is true or false.

Copy link
Collaborator

@sabberworm sabberworm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the phpunit update. Please update and commit the lock file though.

.gitignore Outdated
@@ -1 +1,2 @@
vendor/
composer.lock
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the lock file should remain in the repo, otherwise we’ll get different versions on each install.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sabberworm, thanks for your reply.

Yes. You're right. And I've reverted this :).

@sabberworm sabberworm merged commit c76a5ed into MyIntervals:master Aug 3, 2020
@peter279k peter279k deleted the test_enhancement branch August 5, 2020 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants