Create code coverage during the CI builds #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0f650dd to
e1c642f
Compare
|
Note: This needs the secret |
pierlon
reviewed
Apr 21, 2021
.github/workflows/ci.yml
Outdated
Comment on lines
20
to
46
| include: | ||
| - php-version: 5.3 | ||
| coverage: none | ||
| - php-version: 5.4 | ||
| coverage: none | ||
| - php-version: 5.5 | ||
| coverage: none | ||
| - php-version: 5.6 | ||
| coverage: none | ||
| - php-version: 7.0 | ||
| coverage: none | ||
| - php-version: 7.1 | ||
| coverage: none | ||
| - php-version: 7.2 | ||
| coverage: none | ||
| - php-version: 7.3 | ||
| coverage: none | ||
| - php-version: 7.4 | ||
| coverage: xdebug |
There was a problem hiding this comment.
This could be made simpler with:
Suggested change
| include: | |
| - php-version: 5.3 | |
| coverage: none | |
| - php-version: 5.4 | |
| coverage: none | |
| - php-version: 5.5 | |
| coverage: none | |
| - php-version: 5.6 | |
| coverage: none | |
| - php-version: 7.0 | |
| coverage: none | |
| - php-version: 7.1 | |
| coverage: none | |
| - php-version: 7.2 | |
| coverage: none | |
| - php-version: 7.3 | |
| coverage: none | |
| - php-version: 7.4 | |
| coverage: xdebug | |
| php-version: ['5.3', '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3'] | |
| coverage: ['none'] | |
| include: | |
| - php-version: 7.4 | |
| coverage: xdebug |
There was a problem hiding this comment.
Thanks, @pierlon!
There was a problem hiding this comment.
@oliverklee is there a reason you haven’t followed @pierlon’s suggestion? 52aac78 isn’t included in the proposed changeset.
There was a problem hiding this comment.
I think I included it. Possibly it got lost when I squashed or rebased. I'll update this PR and repush.
There was a problem hiding this comment.
Fixed and repushed.
52aac78 to
d56d808
Compare
The code coverage is only created for one PHP version (the highest version) per build as there is no point to have multiple code coverage uploads for the same code change.
d56d808 to
71c513b
Compare
sabberworm
approved these changes
May 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code coverage is only created for one PHP version (the highest version)
per build as there is no point to have multiple code coverage uploads
for the same code change.