Update most URLs to HTTPS #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westonruter
requested changes
Apr 26, 2021
phpunit.xml
Outdated
| @@ -1,6 +1,6 @@ | |||
| <phpunit | |||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | |||
| xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/4.5/phpunit.xsd" | |||
| xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" | |||
There was a problem hiding this comment.
I don't believe this namespace change is correct. I don't see an HTTPS version for the xsi namespace in the spec: https://www.w3.org/TR/xmlschema-1/
Regardless, a namespace is not intended to be fetched.
Suggested change
| xmlns:xsi="https://www.w3.org/2001/XMLSchema-instance" | |
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" |
There was a problem hiding this comment.
Fixed, rebased and repushed.
There was a problem hiding this comment.
I think this also applies to most namespaces used in CSS @namespace examples.
There was a problem hiding this comment.
Thanks, I'll rework the PR accordingly.
There was a problem hiding this comment.
Changed and repushed.
d12e255 to
5ef5659
Compare
westonruter
approved these changes
Apr 30, 2021
370b83f to
b9abdb5
Compare
|
Rebased and repushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.