List Style Shorthands

[ju1ius]

• Adds CSSRuleSet::expandListStyleShorthand() and CSSRuleSet::createListStyleShorthand()
• Reformated code to match the weird coding conventions of the project...;-)

[ju1ius]

For performance reasons, I'm also considering to store the css rule names and keywords lists used in these methods as static properties, like this:

<?php
class CSSRule {
  static
    $LIST_PROPERTIES = array(
      'list-style-type', 'list-style-position', 'list-style-image'
    ),
    $LIST_PROPERTIES_DEFAULTS = array(
      'list-style-type'     => 'disc',
      'list-style-position' => 'outside',
      'list-style-image'    => 'none'
    );
}
class CSSValue {
  static
    $LIST_STYLE_TYPES = array(
      'none', 'disc', 'circle', 'square', 'decimal-leading-zero', 'decimal',
      'lower-roman', 'upper-roman', 'lower-greek', 'lower-alpha', 'lower-latin',
      'upper-alpha', 'upper-latin', 'hebrew', 'armenian', 'georgian', 'cjk-ideographic',
      'hiragana', 'hira-gana-iroha', 'katakana-iroha', 'katakana'   
    ),
    $LIST_STYLE_POSITIONS = array(
      'inside', 'outside'
    );
}

But I'm wondering wether to add them in the corresponding classes or to create separate repository classes in order to avoid cluttering the source code with long lists of keywords.
What do you think ?

[sabberworm]

I’m against creating static “utility” classes. Put the static method/property where it’s most appropriate. I think your examples are perfect the way they are (no nitpicking this time).