Skip to content

Streamline the existing PHPDoc comments #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 23, 2021

Conversation

oliverklee
Copy link
Collaborator

Make them more useful for static code analysis, for human readers
and for rendering.

@oliverklee
Copy link
Collaborator Author

I have added a second commit that changes @-rule to at-rule as the @ character marks PHPDoc annotations.

@oliverklee
Copy link
Collaborator Author

I'll take care of the rebase in order to resolve the merge conflicts.

Make them more useful for static code analysis, for human readers
and for rendering.
At-rules should be written as "`at-rules`", not as "`@-rules`", as the
`@` character is used to mark PHPDoc annotations.

(In addition, the naming then is consistent with the terminology
used at https://developer.mozilla.org/en-US/docs/Web/CSS/Syntax.)
@oliverklee
Copy link
Collaborator Author

Rebased on top of the latest changes.

@sabberworm sabberworm merged commit afc7f64 into MyIntervals:master Jun 23, 2021
@oliverklee oliverklee deleted the cleanup/phpdoc branch June 23, 2021 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants