Skip to content

Run the tests on CI with all warnings enabled #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

oliverklee
Copy link
Collaborator

This allows us to catch things that will break in future PHP versions, but still kind-of-work, e.g., deprecation warnings or incorrect types.

This allows us to catch things that will break in future PHP versions,
but still kind-of-work, e.g., deprecation warnings or incorrect types.
@sabberworm
Copy link
Collaborator

I think it’s a good idea to catch these but I don’t know how much it brings to the table to log errors to a log file that no-one ever looks at anyway. IMHO the errors should either cause the tests to fail or at least require someone to acknowledge them.

@sabberworm sabberworm merged commit b7eb0b0 into MyIntervals:master Oct 6, 2022
@oliverklee
Copy link
Collaborator Author

AFAIK, the warnings will indeed cause the tests to fail.

@oliverklee oliverklee deleted the task/warnings-in-tests branch October 6, 2022 16:01
@sabberworm
Copy link
Collaborator

AFAIK, the warnings will indeed cause the tests to fail.

Ah, OK, good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants