Add ability to disable mb_* related string functions #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great idea. Could you get rid of the |
|
Yikes, I had actually removed them earlier but choose another fork for the pull request, sorry about that. |
sabberworm
added a commit
that referenced
this pull request
Jun 28, 2012
Add option to use non-multibyte-aware string functions Doing so results in a much better execution time but only if the parsed CSS is guaranteed not to include multibyte characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mb_* functions can be very expensive, for a large document it was taking me over a minute to parse. By disabling these functions it took around 3 seconds and since I know the source of the CSS I'm certain mb_* functions aren't needed.