Skip to content

Conversation

@bartbutler
Copy link
Contributor

Running the test suite was giving me trouble by requiring PHPUnit 5.7, which is quite old. This MR makes the minimal changes necessary to update to 10.2 without modifying the test content in any substantive way.

@sabberworm
Copy link
Collaborator

I think we decided on sticking with 5.7 because it supported all the PHP versions we wanted to test on.

@bartbutler
Copy link
Contributor Author

Of course, that's your prerogative, just noting that I had trouble with it on PHP 8.2 for some reason. and arguably nobody should be using PHP 5 at this point given the vast improvement from 5 to 7.

@sabberworm
Copy link
Collaborator

I definitely think we can finally tackle #251.

@bartbutler
Copy link
Contributor Author

Looks like PHP 5 might finally be below 5% for WP. Anyway, when you decide to do it, this MR is here.

@oliverklee
Copy link
Collaborator

Hey @bartbutler, I'd like to close this in favor of the (merged) #424. As we're keeping support for PHP 7.2 at the moment, we cannot go higher than PHPUnit 8.

I'd still like to have static data providers. Would you be willing to create a new PR for that?

oliverklee added a commit that referenced this pull request Feb 4, 2024
Newer versions of PHPUnit require this, and we might as well do this
now.

Closes #414
@JakeQZ JakeQZ closed this in #443 Feb 5, 2024
JakeQZ pushed a commit that referenced this pull request Feb 5, 2024
Newer versions of PHPUnit require this, and we might as well do this
now.

Closes #414
oliverklee added a commit that referenced this pull request Feb 10, 2024
Newer versions of PHPUnit require this, and we might as well do this
now.

Closes #414
@bartbutler
Copy link
Contributor Author

Took a look and seems to have already been done, so nothing to do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants