[BUGFIX] Invoke PHIVE-installed tools via shell #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hmm, this doesn't seem to be working on Linux now. Though it seems to be the same as what works in the Emogrifier project. |
On Windows, the `.phive` directory contains batch files that in turn invoke the phar installed elsewhere on the system. To be compatible with both Linux and Windows, the file must be invoked directly via the shell, and without a file extension specified (when invoked as well as when installed). Fixes #479.
7d377bc to
0ca714b
Compare
Collaborator
Author
Ah, seems the phars also need to be installed without a file extension, to be compatible with both OSs. |
oliverklee
approved these changes
Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, the
.phivedirectory contains batch files that in turn invoke the phar installed elsewhere on the system. To be compatible with both Linux and Windows, the file must be invoked directly via the shell, and without the file extension specified.Fixes #479.