Better parsing of unknown at rule #53
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This parses rules such as @-moz-document url-prefix() { ... }
Since AtRule needs to generically handle unknown @ rules, it should be a
list instead of a ruleset since the former can handle possible embedded
lists while the latter cannot.
For example, this is CSS from the jquerymobile project:
@-moz-document url-prefix() { .ui-select .ui-btn select { opacity: 0.0001; }}
|
Thanks for the patch but this does not really work so well. A |
sabberworm
added a commit
that referenced
this pull request
Mar 19, 2013
Unknown at-rules stil get to be `RuleSet`s but block rules like document/supports/region-style/font-feature-values are now supported via the AtRuleBlockList class. Also, all at rules now implement the Sabberworm\CSS\Property\AtRule interface. MediaQuery has been removed as its functionality is included fully in the AtRuleBlockList class. Closes #53 as fixed
sabberworm
added a commit
that referenced
this pull request
Mar 19, 2013
Unknown at-rules stil get to be `RuleSet`s but block rules like document/supports/region-style/font-feature-values are now supported via the AtRuleBlockList class. Also, all at rules now implement the Sabberworm\CSS\Property\AtRule interface. MediaQuery has been removed as its functionality is included fully in the AtRuleBlockList class. Closes #53 as fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This parses rules such as @-moz-document url-prefix() { ... }