[TASK] rector: add php70 rule set #549
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks! Please let‘s have separate PRs for the cleanup and the added ruleset (with the cleanup PR first). |
|
Here is the cleanup PR to be merged first: #552 |
7b04d63 to
7c331f5
Compare
|
I dropped the commit with the cleanups from this PR. Sorry for the mess 🙈 |
|
Thanks! And there’s no need to apologize. I’ve merged the cleanup PR now. So this PR here is ready for a rebase now. |
oliverklee
requested changes
Jun 17, 2024
Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
7c331f5 to
76aee91
Compare
|
I rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the rector rule set for PHP 7.0.