[TASK] rector: set PHP rule-set to the same version as composer.json #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now needs a rebase. |
fc031b4 to
a359d6d
Compare
|
And it's rebased. |
This way rector always follows the minimal required version in composer.json. Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
a359d6d to
1284170
Compare
|
And it's rebased again. :) |
oliverklee
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way rector always follows the minimal required version in composer.json, which currently is PHP 7.2.
This helps with #433.