Skip to content

[TASK] rector: set PHP rule-set to the same version as composer.json #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Jun 17, 2024

This way rector always follows the minimal required version in composer.json, which currently is PHP 7.2.

This helps with #433.

@oliverklee
Copy link
Collaborator

This now needs a rebase.

@ziegenberg
Copy link
Contributor Author

And it's rebased.

This way rector always follows the minimal required version in
composer.json.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg force-pushed the add-rector-ruleset-php72 branch from a359d6d to 1284170 Compare June 17, 2024 20:12
@ziegenberg
Copy link
Contributor Author

And it's rebased again. :)

@oliverklee oliverklee merged commit 55e7f21 into MyIntervals:main Jun 18, 2024
18 checks passed
@ziegenberg ziegenberg deleted the add-rector-ruleset-php72 branch June 18, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants