Skip to content

[TASK] Remove DeclarationBlock::getSelector #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2024
Merged

[TASK] Remove DeclarationBlock::getSelector #559

merged 2 commits into from
Jun 18, 2024

Conversation

ziegenberg
Copy link
Contributor

@ziegenberg ziegenberg commented Jun 18, 2024 •
edited
Loading

Removing one function after another.

@ziegenberg ziegenberg force-pushed the remove-deprecated-declarationblock-getselector branch from 88b9c17 to 0478373 Compare June 18, 2024 08:54
@ziegenberg ziegenberg mentioned this pull request Jun 18, 2024
Closed
@ziegenberg ziegenberg changed the title [CLEANUP] Final removal of DeclarationBlock::getSelector [TASK] Remove DeclarationBlock::getSelector Jun 18, 2024
@ziegenberg
Copy link
Contributor Author

I fixed the changelog message.

@ziegenberg ziegenberg force-pushed the remove-deprecated-declarationblock-getselector branch from 4ca7721 to 5dd2934 Compare June 18, 2024 22:52
@ziegenberg
Copy link
Contributor Author

Rebased and force-pushed.

JakeQZ
JakeQZ approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'm fully up-to-speed on all this.

This was already deprecated, with the intention of being removed for the next major release.

Thanks for all this grunt-work; much appreciated <3

@JakeQZ JakeQZ merged commit 0cad1ec into MyIntervals:main Jun 18, 2024
18 checks passed
@JakeQZ JakeQZ added the removal A method, property, or some functionality has been removed. label Jun 18, 2024
@ziegenberg ziegenberg deleted the remove-deprecated-declarationblock-getselector branch June 19, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

Assignees

@ziegenberg ziegenberg

Labels
removal A method, property, or some functionality has been removed.
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@ziegenberg @JakeQZ