[TASK] Always use the strict version of in_array & friends
#584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We'll need some casts first (in a separate PR). |
f6f1163 to
4186cc9
Compare
JakeQZ
requested changes
Jun 25, 2024
src/RuleSet/DeclarationBlock.php
Outdated
Comment on lines
353
to
354
| // Note: font weights should be integers, not floats. For now, we'll keep using floats. We will | ||
| // drill down on this and fix it in https://github.com/MyIntervals/PHP-CSS-Parser/issues/612. |
There was a problem hiding this comment.
This comment needs changing (or removing), now that we have closed #612 on the basis that CSS treats all numerical values as a number, regardless of whether they may be floating-point.
4186cc9 to
7da54fb
Compare
JakeQZ
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.