Skip to content

[BUGFIX] Fix undefined local variable in CalcFunction::parse() #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JakeQZ merged 1 commit into from
Jun 19, 2024
Merged

[BUGFIX] Fix undefined local variable in CalcFunction::parse() #593

JakeQZ merged 1 commit into from
Jun 19, 2024

Conversation

@oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Jun 19, 2024

Fixes #585

@oliverklee oliverklee added the bug label Jun 19, 2024
@oliverklee oliverklee requested review from JakeQZ and sabberworm June 19, 2024 20:55
@oliverklee oliverklee self-assigned this Jun 19, 2024
JakeQZ
JakeQZ approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@JakeQZ JakeQZ merged commit 690e330 into main Jun 19, 2024
@JakeQZ JakeQZ deleted the bugfix/undefined-variable branch June 19, 2024 22:15
oliverklee added a commit that referenced this pull request Jun 23, 2024
@oliverklee
[BUGFIX] Fix undefined local variable in CalcFunction::parse()
b45c81d 
This is the 8.x backport of #593.

Fixes #585
oliverklee added a commit that referenced this pull request Jun 23, 2024
@oliverklee
[BUGFIX] Fix undefined local variable in CalcFunction::parse()
abae36e 
This is the 8.x backport of #593.

Fixes #585
@oliverklee oliverklee mentioned this pull request Jun 23, 2024
Merged
JakeQZ pushed a commit that referenced this pull request Jun 23, 2024
@oliverklee
[BUGFIX] Fix undefined local variable in CalcFunction::parse() (#617)
7d413c8 
This is the 8.x backport of #593.

Fixes #585
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels

bug

Projects

None yet

Milestone

9.0.0: Drop support for PHP < 7.2 and...

Development

Successfully merging this pull request may close these issues.

Possibly undefined local variable

3 participants

@oliverklee @JakeQZ