Skip to content

[CLEANUP] Rector: Add missing return type declaration based on parent class method #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ziegenberg
Copy link
Contributor

This applies the rule AddReturnTypeDeclarationBasedOnParentClassMethodRector. For Details see:
https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#addreturntypedeclarationbasedonparentclassmethodrector

@oliverklee
Copy link
Collaborator

oliverklee commented Jun 21, 2024

I have created #608 to add native return types to parse(). Maybe we can get that in first.

… class method

This applies the rule AddReturnTypeDeclarationBasedOnParentClassMethodRector. For
Details see:
https://github.com/rectorphp/rector/blob/main/docs/rector_rules_overview.md#addreturntypedeclarationbasedonparentclassmethodrector

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg ziegenberg force-pushed the add-type-coverage-level-33 branch from 48c862f to c0d9776 Compare June 24, 2024 12:34
@ziegenberg
Copy link
Contributor Author

I rebased.

@ziegenberg ziegenberg marked this pull request as ready for review June 24, 2024 12:35
Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@oliverklee oliverklee merged commit cc53c85 into MyIntervals:main Jun 24, 2024
18 checks passed
@ziegenberg ziegenberg deleted the add-type-coverage-level-33 branch June 24, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants