Skip to content

Fix Size output for locales that use non-period decimal separators #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

slusarz
Copy link
Contributor

@slusarz slusarz commented Mar 21, 2013

e.g., a locale like pt_PT parses this:

width: 0.15em;

as "0,15".

e.g., a locale like pt_PT parses this:

width: 0.15em;

as "0,15".
@slusarz
Copy link
Contributor Author

slusarz commented Mar 21, 2013

The test case can be a bit misleading since, if the pt_PT locale is not installed on your system and you are using a locale that has '.' as a decimal separator, you will never see this case fail even before the patch.

@sabberworm
Copy link
Collaborator

Well we can’t account for any possibility. I’ve recently had someone point out to me that @keyframes support didn’t work on case-sensitive file systems because the author of the original pull request included the Keyframe class at one point instead of KeyFrame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants