[TASK] Start the contributor guidelines with the CoC #616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e8ef096 to
0c010ff
Compare
JakeQZ
reviewed
Jun 23, 2024
| address, without explicit permission | ||
| * Other conduct which could reasonably be considered inappropriate in a | ||
| professional setting | ||
|
|
There was a problem hiding this comment.
I'd like to keep the CoC as close to the template as much as possible to make upgrades easier. If we think that think need improving there, I suggest we create a PR at their repo instead:
https://github.com/EthicalSource/contributor_covenant/
There was a problem hiding this comment.
Seems this comment should be in the general discussion, rather than a reply to specific review comment.
There was a problem hiding this comment.
There's still a superfluous blank line.
JakeQZ
requested changes
Jun 25, 2024
This is the first part of #489. I'd like to add sections bit by bit to make reviewing easier and faster, and to allow us to get things online quickly. This file will be in sync with its counterpart in the Emogrifier project as much as possible.
9005573 to
654d143
Compare
JakeQZ
approved these changes
Jun 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first part of #489.
I'd like to add sections bit by bit to make reviewing easier and faster, and to allow us to get things online quickly.
This file will be in sync with its counterpart in the Emogrifier project as much as possible.