[BUGFIX] Provide the usual set of delimiters in parseValue tests #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the test cases added so far, this doesn't seem to affect results, but would be needed for tests that may be added in future to ensure consistencey with how the method is actually used at runtime.
|
@JakeQZ Friendly note to do the backport. :-) |
I was planning to do these once all the relavant changes have been approved on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the test cases added so far, this doesn't seem to affect results, but would be needed for tests that may be added in future to ensure consistencey with how the method is actually used at runtime.