Skip to content

[CLEANUP] Always escape backslashes in strings #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2024
Merged

[CLEANUP] Always escape backslashes in strings #639

merged 2 commits into from
Jul 3, 2024

Conversation

oliverklee
Copy link
Collaborator

This was done using the string_implicit_backslashes PHP-CS-Fixer rule.

@oliverklee oliverklee requested review from sabberworm and JakeQZ July 2, 2024 08:12
@oliverklee oliverklee self-assigned this Jul 2, 2024
@oliverklee
[CLEANUP] Always escape backslashes in strings
9179703 
This was done using the `string_implicit_backslashes` PHP-CS-Fixer rule.
JakeQZ
JakeQZ requested changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some of the regex patterns with the PCRE_EXTENDED modifier, the comments have become misaligned. Otherwise looks fine.

src/Property/KeyframeSelector.php Outdated
)*
)|
(\d+%) # keyframe animation progress percentage (e.g. 50%)
(\\d+%) # keyframe animation progress percentage (e.g. 50%)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the comment here neeeds moving to align with the others.

src/Property/Selector.php Outdated
|
(\:( # pseudo classes
(\\:( # pseudo classes
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

src/Property/Selector.php Outdated
|
\:{1,2}( # pseudo-elements
\\:{1,2}( # pseudo-elements
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And here.

@oliverklee
Copy link
Collaborator Author

Fixed the alignments and repushed.

@oliverklee oliverklee requested a review from JakeQZ July 3, 2024 07:09
JakeQZ
JakeQZ approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine now.

@JakeQZ JakeQZ merged commit 8f2ba48 into main Jul 3, 2024
18 checks passed
@JakeQZ JakeQZ deleted the cleanup/fixer-5 branch July 3, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
cleanup
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ