Skip to content

Escaped quotes parsing #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
raxbg wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Escaped quotes parsing #646

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa00e4c
Parse escape quoted values
Mar 28, 2024
6178a81
Add escaped quotes parsing unit test
Mar 29, 2024
730e8fa
Merge branch 'main' into improve/escaped_quotes_parsing
raxbg Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Merge branch 'main' into improve/escaped_quotes_parsing
  • Loading branch information
@raxbg
raxbg committed Jul 10, 2024
commit 730e8fa7bacaba91b4fb5980391693c0728b4065
2 changes: 1 addition & 1 deletion src/Value/Value.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public static function parsePrimitiveValue(ParserState $oParserState)
} elseif ($oParserState->comes('#') || $oParserState->comes('rgb', true) || $oParserState->comes('hsl', true)) {
$oValue = Color::parse($oParserState);
} elseif (
in_array($oParserState->peek(), self::PARSE_QUOTE_STRINGS)
in_array($oParserState->peek(), self::PARSE_QUOTE_STRINGS)
|| in_array($oParserState->peek(2), self::PARSE_QUOTE_STRINGS)
) {
$oValue = CSSString::parse($oParserState);
Expand Down
2 changes: 1 addition & 1 deletion tests/ParserTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ public function parseForEscapedQuotes()
self::assertEquals($expectedCss, $postParseCss);
}

public function escapedSpecialCaseTokens()
public function escapedSpecialCaseTokens(): void
{
$oDoc = $this->parsedStructureForFile('escaped-tokens');
$contents = $oDoc->getContents();
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.