Skip to content

[TASK] Switch our code coverage CI from Codacy to Coveralls #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 28, 2024
Merged

[TASK] Switch our code coverage CI from Codacy to Coveralls #659

merged 1 commit into from
Aug 28, 2024

Conversation

oliverklee
Copy link
Collaborator

@oliverklee oliverklee commented Aug 23, 2024 •
edited
Loading

Coveralls does not require an API key, provides a nice GitHub Action, and it can post code coverage comments to PRs.

Also add a code coverage badge to the README.

Also align the GitHub Action workflow with that of our sister project Emogrifier.

Also add a Composer script for running the tests with coverage.

Fixes #535
Fixes #299

@oliverklee oliverklee self-assigned this Aug 23, 2024
@oliverklee oliverklee marked this pull request as draft August 23, 2024 14:30
@oliverklee oliverklee force-pushed the task/coveralls branch 4 times, most recently from e349af5 to 015ce2a Compare August 23, 2024 14:34
@oliverklee oliverklee marked this pull request as ready for review August 23, 2024 14:37
@oliverklee
Copy link
Collaborator Author

Note: As far as I understand it, Coveralls requires the coverage job to have been run for the main branch at least once before it will start to post the change to the coverage numbers on PRs.

@oliverklee
[TASK] Switch our code coverage CI from Codacy to Coveralls
5786333 
Coveralls does not require an API key, provides a nice GitHub Action,
and it can post code coverage comments to PRs.

Also add a code coverage badge to the README.

Also align the GitHub Action workflow with that of our sister project
Emogrifier.

Also add a Composer script for running the tests with coverage.

Fixes #535
Fixes #299
JakeQZ
JakeQZ approved these changes Aug 28, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I maybe should have reviewed this before MyIntervals/emogrifier#1160. Might have made it easier.

Anyway, this change is consistent with that, and looks OK AFAICT.

@JakeQZ JakeQZ merged commit ba3948e into main Aug 28, 2024
21 checks passed
@JakeQZ JakeQZ deleted the task/coveralls branch August 28, 2024 01:56
@JakeQZ
Copy link
Collaborator

JakeQZ commented Aug 28, 2024

Also
Also
Also

What happened to 'one change per commit'? I'm fine with it either way, and also don't want to unnecessarily put off contributors by requesting they break their PRs into more manageable chunks.

@oliverklee
Copy link
Collaborator Author

What happened to 'one change per commit'?

Thanks for the reminder - it seems I got lazy. I'll do my best to do more atomic PRs, including pre-PRs, and mark the blocked PRs as drafts in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.

Switch the code coverage to Coveralls Add a code coverage badge to the README
2 participants
@oliverklee @JakeQZ