Skip to content

[TASK] Document the general contribution workflow #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 27, 2024
Merged

[TASK] Document the general contribution workflow #662

merged 4 commits into from
Aug 27, 2024

Conversation

oliverklee
Copy link
Collaborator

Part of #489

@oliverklee oliverklee self-assigned this Aug 23, 2024
JakeQZ
JakeQZ reviewed Aug 25, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awaiting resolution of MyIntervals/emogrifier#1282

@JakeQZ JakeQZ added the blocked Needs another issue to be resolved first label Aug 25, 2024
@oliverklee oliverklee force-pushed the task/contribution-workflow branch from 8097f0b to ef3753b Compare August 26, 2024 14:53
@oliverklee oliverklee requested a review from JakeQZ August 26, 2024 14:53
JakeQZ
JakeQZ reviewed Aug 26, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still an issue or two to resolve with MyIntervals/emogrifier#1282. Once sorted, we can have the two in sync.

@oliverklee oliverklee force-pushed the task/contribution-workflow branch from ef3753b to f9f93ae Compare August 27, 2024 06:51
@oliverklee oliverklee requested a review from JakeQZ August 27, 2024 06:51
JakeQZ
JakeQZ approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mirrors the equivalent section in the sister project contribution guidelines (though without the intradocument links to sections yet to be added: development dependencies; unit testing; coding style; commit messages).

@JakeQZ JakeQZ merged commit b0d6c4e into main Aug 27, 2024
20 checks passed
@JakeQZ JakeQZ deleted the task/contribution-workflow branch August 27, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
blocked Needs another issue to be resolved first documentation
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
2 participants
@oliverklee @JakeQZ