[TASK] Block installations on unsupported higher PHP versions #691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverklee
added a commit
that referenced
this pull request
Aug 28, 2024
We want Composer to be able to figure out which versions of which libraries it can install on which version of PHP. To make this possible, we should only allow installations on PHP versions that we know to work. This is the v8.x backport of #691.
oliverklee
added a commit
that referenced
this pull request
Aug 28, 2024
We want Composer to be able to figure out which versions of which libraries it can install on which version of PHP. To make this possible, we should only allow installations on PHP versions that we know to work. This is the v8.x backport of #691.
We want Composer to be able to figure out which versions of which libraries it can install on which version of PHP. To make this possible, we should only allow installations on PHP versions that we know to work.
a073d11 to
0ac6ecb
Compare
JakeQZ
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
This is what we do in the sister project, Emogrifier. It means we have to specifically make a release to support each new PHP version. But that also involves updating the automated tests to include testing against the new PHP. Thus we can be confident that the software works with it, having made any changes needed, as opposed to finding spurious bugs in the wild.
JakeQZ
pushed a commit
that referenced
this pull request
Aug 28, 2024
We want Composer to be able to figure out which versions of which libraries it can install on which version of PHP. To make this possible, we should only allow installations on PHP versions that we know to work. This is the v8.x backport of #691.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want Composer to be able to figure out which versions of which libraries it can install on which version of PHP.
To make this possible, we should only allow installations on PHP versions that we know to work.