Skip to content

[TASK] Drop the highest/lowest Composer version switch #698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

oliverklee
Copy link
Collaborator

As we don't have any direct production dependencies, it does not make sense to test both with highest and lowest Composer versions on CI.

We accidentally added this highest/lowest switch with the new coverage job. This commit removes this again, allowing for sharing the Composer caches with the main CI job.

As we don't have any direct production dependencies, it does not make
sense to test both with highest and lowest Composer versions on CI.

We accidentally added this highest/lowest switch with the new coverage
job. This commit removes this again, allowing for sharing the Composer
caches with the main CI job.
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were only using dependencies: highest in the code coverage matrix. But the CI workflow does not have that dimension to the matrix (the axes of which are used for the cache key).

@JakeQZ
Copy link
Collaborator

JakeQZ commented Sep 2, 2024

We may actually need the composer install step as well as composer update - see MyIntervals/emogrifier#924. I think we had some CI builds randomly failing. However, if it's still a problem (it may have been fixed by GitHub), it would also be needed for the CI build, which doesn't have it. Anyway, if we do get a random build failure at composer update, we'll know what to do.

@JakeQZ JakeQZ merged commit 09d35ce into main Sep 2, 2024
21 checks passed
@JakeQZ JakeQZ deleted the task/no-highest branch September 2, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants