Fix case-insensitive dimension/keyword determination #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test-case was a bit broken though - it changed the case of the Hz keyword which isn't clear from the documentation. Better solution is to preserve the case in the original input.
|
No, the test case was not broken. The CSS parser is designed to parse valid CSS but to parse it into comparable structures which it won’t be if we leave the case intact for case-insensitive tokens.. Besides, I wasn’t telling you so you could fix this, I already have a fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test-case was a bit broken though - it changed the case of the Hz
keyword which isn't clear from the documentation. Better solution is to
preserve the case in the original input.