[DOCS] Add an API and deprecation policy #720
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed here: #715
JakeQZ
requested changes
Sep 14, 2024
There was a problem hiding this comment.
Just some typos in one sentence.
It occurs to me that we ourselves need to track when we mark something as @internal to ensure we don't make make any breaking changes before the next major release since doing so. I don't know if we can use something like "@internal may be changed or removed without notice from version 9.0.0" in the PHPDoc. This doesn't affect this PR, I'm just concerned that we might for example start making breaking changes to a class marked as @internal for 8.7 for a bugfix which is then included in 8.7.1, not realizing (or forgetting) it had not been marked @internal in 8.6.
Co-authored-by: JakeQZ <jake@qzdesign.co.uk>
JakeQZ
approved these changes
Sep 18, 2024
oliverklee
added a commit
to MyIntervals/emogrifier
that referenced
this pull request
Sep 19, 2024
This is exactly the same change as in our sister project, PHP-CSS-Parser: MyIntervals/PHP-CSS-Parser#720
oliverklee
added a commit
to MyIntervals/emogrifier
that referenced
this pull request
Sep 19, 2024
This is exactly the same change as in our sister project, PHP-CSS-Parser: MyIntervals/PHP-CSS-Parser#720
oliverklee
added a commit
to MyIntervals/emogrifier
that referenced
this pull request
Sep 19, 2024
This is exactly the same change as in our sister project, PHP-CSS-Parser: MyIntervals/PHP-CSS-Parser#720
JakeQZ
pushed a commit
to MyIntervals/emogrifier
that referenced
this pull request
Sep 19, 2024
This is exactly the same change as in our sister project, PHP-CSS-Parser: MyIntervals/PHP-CSS-Parser#720
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here:
#715