Add of the removeSelector from Block (previously in the todo list)

[odinduclos]

No description provided.

[sabberworm]

Thanks for the pull request. I think I will merge this. However, I’ll add a unit test first.

Also, there are some issues with this new method:

1. What I meant with the item on my to-do-list was more of a removeDeclarationBlocksWithSelector method so this does not quite address what I saw lacking.
2. What if the selector that was removed was the last one? Shouldn’t that result in the removal of the whole declaration block?
3. I think removeSelector should return true or false depending on whether or not the selector had been found.
4. Currently, the CSS Parser does not parse selectors (another item on the to-do-list) so it has no way of knowing that .header>table and .header > table (note the spaces) are just two ways of writing the same. In my opinion, the removeSelector function should work with both forms of input.

Still even with those issues, I can see no reason for not having this method in.

[sabberworm]

Oh, I see, I did add a removeDeclarationBlockBySelector method at some point so I’ll remove the to-do item.

[odinduclos]

I Will do a longer talk tomorrow. But yeah i used your function in my code
with a simple count getSelectors. Thx for thé answer!
Le 30 juin 2014 20:33, "Raphael Schweikert" notifications@github.com a
écrit :

Oh, I see, I did add a removeDeclarationBlockBySelector method at some
point so I’ll remove the to-do item.

—
Reply to this email directly or view it on GitHub
#77 (comment)
.

[sabberworm]

I had to change some stuff but I hope it’s still what you wanted.