Skip to content

[FEATURE] Parse color functions with modern syntax #800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Jan 23, 2025

Also include tests for color functions with CSS variable substitutions where they use the "legacy" syntax.

Resolves #755.

Also include tests for color functions with CSS variable substitutions where
they use the "legacy" syntax.

Resolves #755.
@JakeQZ JakeQZ added enhancement css4 Relating to features introduced in CSS4 labels Jan 23, 2025
@JakeQZ JakeQZ self-assigned this Jan 23, 2025
@coveralls
Copy link

coveralls commented Jan 23, 2025

Coverage Status

coverage: 41.942% (+0.6%) from 41.369%
when pulling ed97ed2 on feature/css-color-4-parsing
into 9e79e16 on main.

Copy link
Collaborator

@oliverklee oliverklee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow… ❤️

CHANGELOG.md Outdated
- `rgb` and `rgba`, and `hsl` and `hsla` are now aliases (#797}
- Parse color functions that use the "modern" syntax
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Parse color functions that use the "modern" syntax
- Parse color functions that use the "modern" syntax (#800)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd intended to do this once I'd determined what the PR number would be, but then forgot. Now added.

@JakeQZ JakeQZ requested a review from oliverklee January 23, 2025 22:00
@oliverklee oliverklee merged commit 9c70d85 into main Jan 23, 2025
21 checks passed
@oliverklee oliverklee deleted the feature/css-color-4-parsing branch January 23, 2025 23:03
@JakeQZ
Copy link
Collaborator Author

JakeQZ commented Jan 23, 2025

Wow… ❤️

I'd done most of this before I figured that the parse method should probably first be split up.

I've added #801 to capture all tasks and issues relating to colours that I can think of, while I'm in this neck of the woods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css4 Relating to features introduced in CSS4 enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing RGB with alpha is broken
3 participants