[TASK] Use native void return type declarations
#805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also include previous changes for adding native type declarations or strict mode into the changelog.
|
This will probably clash with #804. |
JakeQZ
approved these changes
Jan 25, 2025
| */ | ||
| protected function allDeclarationBlocks(array &$aResult) | ||
| protected function allDeclarationBlocks(array &$aResult): void |
There was a problem hiding this comment.
Can't help thinking that these all... methods should perhaps be returning the result, rather than having it as a parameter passed by reference - unless the array is supposed to be merged with some original array - but that is beyond the scope of this PR.
There was a problem hiding this comment.
Looked at the code, and these functions call each other to build up the array, so it does need to be a parameter passed by reference.
I used the visual merge, which seems to have worked OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also include previous changes for adding native type declarations or strict mode into the changelog.