-
Notifications
You must be signed in to change notification settings - Fork 144
[DOCS] Integrate the 8.x
changelog into the main
changelog
#806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f7a8227
to
3c1b281
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of the 8.x changelog entries reference backport PRs, whereas some reference the equivalent change on main
.
I think they should be all one or all the other. I'm leaning towards referencing the changes on main
, and have identified the equivalents.
Either way, it would mean the changelog no longer exactly matching the release notes (with some different, but equivalent PRs being referenced). If it's important for the changelog to match the release notes, then the mishmash of referenced PRs can be retained...
3c1b281
to
98b430c
Compare
Thanks! Yes, that makes sense. |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one typo. Everything else looks fine now.
09c3a92
to
4108220
Compare
Rebased and updated. |
4108220
to
18cd6f4
Compare
Is this ready for review now - it's still marked as draft? |
Oh, sorry, forgot that. Yes, it's ready for review now. |
Now the changelog up to the latest feature release 8.7.0 is part of the `main` changelog. This makes it easier to see what has changed after the last feature release. Also, this makes it clear in which release some methods were deprecated, avoid the impression that methods got both deprecated and removed in the same release. Also autoformat the changelog.
Co-authored-by: JakeQZ <jake@qzdesign.co.uk>
18cd6f4
to
f557cf8
Compare
Now the changelog up to the latest feature release 8.7.0 is part of the
main
changelog.This makes it easier to see what has changed after the last feature release.
Also, this makes it clear in which release some methods were deprecated, avoid the impression that methods got both deprecated and removed in the same release.
Also autoformat the changelog.