[TASK] Drop the PHIVE-installed development tools in V8.x #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
333124c to
16426d4
Compare
16426d4 to
81b1114
Compare
It has turned out that our current set of PHIVE-installed development tools for the V8.x maintenance branch is no longer installable due to issues with the GPG keys used for signing the PHARs. As the maintenance branch has very little activity anyway now, relying on PHP linting and the unit tests should suffice, saving us the hassle with PHIVE on that branch. (We're still keeping some `.gitignore` entries related to the tools to make switching branches easier.) Closes #831 Closes #830
81b1114 to
f7f2763
Compare
JakeQZ
approved these changes
Jan 27, 2025
There was a problem hiding this comment.
We still have the unit tests which should catch any major mistakes. The other tools check for coding style and integrity, and have only relatively recently been added.
I've forgotton the reason for having the other tools installed with PHIVE rather than Composer.
|
The reason was that the latest version of the tools (which we want to use) does not cover the PHP version range we support, and hence would make any |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has turned out that our current set of PHIVE-installed development tools for the V8.x maintenance branch is no longer installable due to issues with the GPG keys used for signing the PHARs.
As the maintenance branch has very little activity anyway now, relying on PHP linting and the unit tests should suffice, saving us the hassle with PHIVE on that branch.
(We're still keeping some
.gitignoreentries related to thetools to make switching branches easier.)
Closes #831
Closes #830