Skip to content

[TASK] Add more tests for OutputFormat #868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 2, 2025
Merged

[TASK] Add more tests for OutputFormat #868

merged 1 commit into from
Feb 2, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Feb 2, 2025
@oliverklee oliverklee marked this pull request as draft February 2, 2025 15:00
@coveralls
Copy link

coveralls commented Feb 2, 2025 •
edited
Loading

Coverage Status

coverage: 45.742% (+0.4%) from 45.347%
when pulling 6bd3476 on task/more-outputformat-tests
into 5fe6db9 on main.

@oliverklee oliverklee force-pushed the task/more-outputformat-tests branch 2 times, most recently from fcce3a1 to 94390f1 Compare February 2, 2025 17:48
@oliverklee oliverklee marked this pull request as ready for review February 2, 2025 17:48
@oliverklee oliverklee marked this pull request as draft February 2, 2025 17:54
@oliverklee oliverklee force-pushed the task/more-outputformat-tests branch from 94390f1 to 6bd3476 Compare February 2, 2025 17:55
@oliverklee oliverklee marked this pull request as ready for review February 2, 2025 17:55
JakeQZ
JakeQZ requested changes Feb 2, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the tests is using a method that has just been deprecated.

JakeQZ
JakeQZ approved these changes Feb 2, 2025
View reviewed changes
@JakeQZ JakeQZ merged commit 19cccef into main Feb 2, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/more-outputformat-tests branch February 2, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ