Skip to content

[TASK] Raise PHPStan to level 2 #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2025
Merged

[TASK] Raise PHPStan to level 2 #877

merged 1 commit into from
Feb 7, 2025

Conversation

oliverklee
Copy link
Collaborator

No description provided.

@oliverklee oliverklee self-assigned this Feb 4, 2025
@oliverklee oliverklee marked this pull request as draft February 4, 2025 21:11
@coveralls
Copy link

coveralls commented Feb 4, 2025 •
edited
Loading

Coverage Status

coverage: 49.156%. remained the same
when pulling c5dcfb3 on task/phpstan-level-2
into 88b8729 on main.

@oliverklee oliverklee force-pushed the task/phpstan-level-2 branch from 09169d6 to 102d626 Compare February 6, 2025 16:19
@oliverklee oliverklee changed the title [TASK] Raise PHPStan checks to level 2 [TASK] Raise PHPStan to level 2 Feb 7, 2025
@oliverklee oliverklee force-pushed the task/phpstan-level-2 branch from 102d626 to c5dcfb3 Compare February 7, 2025 09:09
@oliverklee oliverklee marked this pull request as ready for review February 7, 2025 09:10
JakeQZ
JakeQZ approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@JakeQZ JakeQZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't matter whether we resolve the issues reported before or after bumping the checking level.

@JakeQZ JakeQZ merged commit cb3ae4b into main Feb 7, 2025
21 checks passed
@JakeQZ JakeQZ deleted the task/phpstan-level-2 branch February 7, 2025 18:21
@oliverklee
Copy link
Collaborator Author

I actually prefer resolving them after bumping the level, because seeing my changes remove an issue feels really good to me. 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JakeQZ JakeQZ JakeQZ approved these changes

@sabberworm sabberworm Awaiting requested review from sabberworm

Assignees

@oliverklee oliverklee

Labels
None yet
Projects
None yet
Milestone
9.0.0: Drop support for PHP < 7.2 and...
Development

Successfully merging this pull request may close these issues.
3 participants
@oliverklee @coveralls @JakeQZ