Skip to content

[CLEANUP] Add separate OutputFormat properties for arrays #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

JakeQZ
Copy link
Collaborator

@JakeQZ JakeQZ commented Feb 7, 2025

SpaceBeforeListArgumentSeparators and SpaceAfterListArgumentSeparators are added to allow for different spacing for different separators.

SpaceBeforeListArgumentSeparator and SpaceAfterListArgumentSeparator will specify the default spacing. Setting these as an array is deprecated.

This is the backport of #880.

@JakeQZ JakeQZ added cleanup enhancement deprecation A method, property, or some functionality has been deprecated. backport labels Feb 7, 2025
@JakeQZ JakeQZ added this to the 8.8.0 milestone Feb 7, 2025
@JakeQZ JakeQZ requested a review from oliverklee February 7, 2025 00:02
@JakeQZ JakeQZ self-assigned this Feb 7, 2025
@JakeQZ JakeQZ force-pushed the cleanup/v8/list-separator-space branch from 36ea6b9 to 559c851 Compare February 7, 2025 00:08
`SpaceBeforeListArgumentSeparators` and `SpaceAfterListArgumentSeparators`
are added to allow for different spacing for different separators.

`SpaceBeforeListArgumentSeparator` and `SpaceAfterListArgumentSeparator`
will specify the default spacing.  Setting these as an array is deprecated.

This is the backport of #880.
@JakeQZ JakeQZ force-pushed the cleanup/v8/list-separator-space branch from 559c851 to d86998d Compare February 7, 2025 00:22
@oliverklee oliverklee merged commit a806d0a into v8.x Feb 7, 2025
22 checks passed
@oliverklee oliverklee deleted the cleanup/v8/list-separator-space branch February 7, 2025 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport cleanup deprecation A method, property, or some functionality has been deprecated. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants